Skip to content

[fix] Trigger changelog bot for backward incompatible changes#521

Merged
nemesifier merged 1 commit into
masterfrom
changelog-bot-change-bang
May 27, 2026
Merged

[fix] Trigger changelog bot for backward incompatible changes#521
nemesifier merged 1 commit into
masterfrom
changelog-bot-change-bang

Conversation

@nemesifier

@nemesifier nemesifier commented May 26, 2026

Copy link
Copy Markdown
Member

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

No existing issue.

Description of Changes

This PR updates the changelog bot trigger workflow to match PR titles starting with [change!].

This allows backward incompatible PRs to run the reusable changelog workflow after maintainer approval, the same as [feature], [fix], and [change] PRs.

Screenshot

Not applicable.

@nemesifier
[fix] Triggered changelog bot for backward incompatible changes
27f3970 
Update the changelog bot trigger so PR titles marked with [change!] run the reusable changelog workflow.
@coderabbitai

coderabbitai Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1a2e3036-f6ec-4d34-86a2-cc39665725b3

📥 Commits

Reviewing files that changed from the base of the PR and between 187ed1a and 27f3970.

📒 Files selected for processing (1)
  • .github/workflows/bot-changelog-trigger.yml
📜 Recent review details
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-04-17T20:35:58.550Z 
Learnt from: nemesifier
Repo: openwisp/openwisp-users PR: 496
File: .github/workflows/bot-changelog-runner.yml:27-27
Timestamp: 2026-04-17T20:35:58.550Z
Learning: In the openwisp/openwisp-users repository, do not require pinning GitHub Actions to full commit SHAs for supply-chain security. It’s acceptable to reference actions using mutable major version tags like `actions/download-artifactv4`. When reviewing workflow YAML files, avoid raising comments specifically about SHA pinning for GitHub Actions in this repo.

Applied to files:

  • .github/workflows/bot-changelog-trigger.yml
🔇 Additional comments (1)
.github/workflows/bot-changelog-trigger.yml (1)

23-23: LGTM!

📝 Walkthrough

Walkthrough

The PR updates the bot changelog trigger workflow to recognize [change!] as a noteworthy PR title prefix in addition to [change]. The grep regex pattern is modified from change to change!? to match titles with an optional trailing exclamation mark, allowing the changelog automation to flag breaking change annotations consistently.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openwisp/openwisp-users#496: Related update to the same bot-changelog-trigger.yml workflow file, modifying the PR-title matching regex.

Suggested labels

github_actions

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the changelog bot trigger to handle backward incompatible changes marked with [change!].
Description check ✅ Passed The description addresses the key requirement sections including checklist items, reference to existing issue, and detailed description of changes, though test and documentation updates are not checked.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Bug Fixes ✅ Passed PR is a one-line fix to a GitHub Actions workflow file, both valid exceptions to the regression test requirement per the custom check instructions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch changelog-bot-change-bang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the github_actions Pull requests that update GitHub Actions code label May 26, 2026
@coveralls

coveralls commented May 26, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 98.163%. remained the same — changelog-bot-change-bang into master

@nemesifier nemesifier merged commit f9f7e11 into master May 27, 2026
24 checks passed
@nemesifier nemesifier deleted the changelog-bot-change-bang branch May 27, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nemesifier @coveralls